Discussion:
Did someone enable warnings=errors for more files?
David Chase
2014-10-16 21:37:55 UTC
Permalink
Rhetorical question, actually ? someone clearly did.
Someone also did not test it with gcc 4.8.recent on Ubuntu 14 or Clang.current on Mavericks.

One of the offending directories is fdlibm, and I have experience with that, so since I can?t
get anything else done, I will see about cleaning up that code.

David
Joe Darcy
2014-10-16 22:20:33 UTC
Permalink
David,

I think it is more appropriate to look to compile fdlibm with a
different set of flags, as has been done in at least previous iterations
of the build system.

Thanks,

-Joe
Post by David Chase
Rhetorical question, actually ? someone clearly did.
Someone also did not test it with gcc 4.8.recent on Ubuntu 14 or Clang.current on Mavericks.
One of the offending directories is fdlibm, and I have experience with that, so since I can?t
get anything else done, I will see about cleaning up that code.
David
David Chase
2014-10-17 01:08:27 UTC
Permalink
I am more competent at modifying FP source code than I am at tinkering with flags in our build system.
If someone else is solving the problem, they might choose what works best for them, I am glad if that happens.
But till something happens, I am (very) build-impaired, or I can just make all my changes to a downrev
version of the source and hope that the patches apply.

David
Post by Joe Darcy
David,
I think it is more appropriate to look to compile fdlibm with a different set of flags, as has been done in at least previous iterations of the build system.
Thanks,
-Joe
Post by David Chase
Rhetorical question, actually ? someone clearly did.
Someone also did not test it with gcc 4.8.recent on Ubuntu 14 or Clang.current on Mavericks.
One of the offending directories is fdlibm, and I have experience with that, so since I can?t
get anything else done, I will see about cleaning up that code.
David
Joe Darcy
2014-10-17 04:45:28 UTC
Permalink
Changes to fdlibm code should be review on core-libs-dev rather than
build-dev.

However, given the nature of the code, I am not inclined to approach
changes to fdlibm to work around new C compiler warnings.

-Joe
Post by David Chase
I am more competent at modifying FP source code than I am at tinkering with flags in our build system.
If someone else is solving the problem, they might choose what works best for them, I am glad if that happens.
But till something happens, I am (very) build-impaired, or I can just make all my changes to a downrev
version of the source and hope that the patches apply.
David
Post by Joe Darcy
David,
I think it is more appropriate to look to compile fdlibm with a different set of flags, as has been done in at least previous iterations of the build system.
Thanks,
-Joe
Post by David Chase
Rhetorical question, actually ? someone clearly did.
Someone also did not test it with gcc 4.8.recent on Ubuntu 14 or Clang.current on Mavericks.
One of the offending directories is fdlibm, and I have experience with that, so since I can?t
get anything else done, I will see about cleaning up that code.
David
David Chase
2014-10-17 12:39:33 UTC
Permalink
Problem was caused by skewed repos checked out with old (now broken) conventions.

David
Changes to fdlibm code should be review on core-libs-dev rather than build-dev.
However, given the nature of the code, I am not inclined to approach changes to fdlibm to work around new C compiler warnings.
-Joe
Post by David Chase
I am more competent at modifying FP source code than I am at tinkering with flags in our build system.
If someone else is solving the problem, they might choose what works best for them, I am glad if that happens.
But till something happens, I am (very) build-impaired, or I can just make all my changes to a downrev
version of the source and hope that the patches apply.
David
Post by Joe Darcy
David,
I think it is more appropriate to look to compile fdlibm with a different set of flags, as has been done in at least previous iterations of the build system.
Thanks,
-Joe
Post by David Chase
Rhetorical question, actually ? someone clearly did.
Someone also did not test it with gcc 4.8.recent on Ubuntu 14 or Clang.current on Mavericks.
One of the offending directories is fdlibm, and I have experience with that, so since I can?t
get anything else done, I will see about cleaning up that code.
David
Loading...