[8u40] Request for approval and review: JDK-8059135: New Nasgen dependencies to Nashorn breaks the JDK 9 build

Discussion:

[8u40] Request for approval and review: JDK-8059135: New Nasgen dependencies to Nashorn breaks the JDK 9 build - bootstrapping problem?

Erik Joelsson

2014-10-07 08:33:20 UTC

Permalink

Hello,

Please review and approve this backport from jdk9 to jdk8u40. The patch
does not apply cleanly, but with a slight reduction it works just as well.

The Bug: https://bugs.openjdk.java.net/browse/JDK-8059135
The jdk9 review:
http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-October/003568.html
The jdk8u-dev webrev:
http://cr.openjdk.java.net/~erikj/8059135/webrev.nashorn.01.jdk8u/

/Erik

Seán Coffey

2014-10-07 11:14:41 UTC

Permalink

Approved but subject to a code review. Please add a noreg- label to the
bug report also.

regards,
Sean.

Post by Erik Joelsson
Hello,
Please review and approve this backport from jdk9 to jdk8u40. The
patch does not apply cleanly, but with a slight reduction it works
just as well.
The Bug: https://bugs.openjdk.java.net/browse/JDK-8059135
http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-October/003568.html
http://cr.openjdk.java.net/~erikj/8059135/webrev.nashorn.01.jdk8u/
/Erik

Tim Bell

2014-10-07 13:37:18 UTC

Permalink

Erik:

Code review looks good to me.

Tim

Post by SeÃ¡n Coffey
Approved but subject to a code review. Please add a noreg- label to
the bug report also.
regards,
Sean.

Marcus Lagergren

2014-10-08 09:17:57 UTC

Permalink

Looks good!
/M

Post by Erik Joelsson
Hello,
Please review and approve this backport from jdk9 to jdk8u40. The patch does not apply cleanly, but with a slight reduction it works just as well.
The Bug: https://bugs.openjdk.java.net/browse/JDK-8059135
The jdk9 review: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-October/003568.html
The jdk8u-dev webrev: http://cr.openjdk.java.net/~erikj/8059135/webrev.nashorn.01.jdk8u/
/Erik