[8u40]: RFR 8059136: Reverse removal of applet demos

Discussion:

Daniil Titov

2014-09-26 20:48:35 UTC

Hi,

Please review webrev that reverses changes done in the team forest
(https://bugs.openjdk.java.net/browse/JDK-8015376 removal of applet demos).

JDK-8015376 changes were integrated in 8u-dev team forest only, so there
in nothing to reverse in JDK 9.

Both changesets will have to come through 8u-dev forest.

Bug: https://bugs.openjdk.java.net/browse/JDK-8059136
8u40 webrev: http://cr.openjdk.java.net/~dtitov/8059136/webrev.00
<http://cr.openjdk.java.net/%7Edtitov/8059136/webrev.00>

Thanks!
Daniil

-------- Original Message --------
Subject: Re: Request for Approval: 8015376 - Remove jnlp and applet
files from the JDK samples
Date: Thu, 25 Sep 2014 10:01:17 +0100
From: Se?n Coffey <sean.coffey at oracle.com>
To: daniil titov <daniil.x.titov at oracle.com>, jdk8u-dev at openjdk.java.net

Please add a suitable noreg- label to bug report. (noreg-build I guess)

Approved.

regards,
Sean.

Please approve the changes that remove applets from JDK samples. 8u40
changes were already integrated in the team forest. They were reviewed
by the team members at time of integration. JDK 9 changes are ready
for integration as well.
Bug: https://bugs.openjdk.java.net/browse/JDK-8015376
JDK 8u40 webrev: http://cr.openjdk.java.net/~dtitov/8015376/webrev.00
<http://cr.openjdk.java.net/%7Edtitov/8015376/webrev.00>
JDK 9 webrev: http://cr.openjdk.java.net/~dtitov/8015376.9/webrev.00
<http://cr.openjdk.java.net/%7Edtitov/8015376.9/webrev.00>
Thanks,
Daniil

Pete Brunet

2014-09-29 19:00:15 UTC

Permalink

Hi Daniil, I reviewed the two webrevs
original change: http://cr.openjdk.java.net/~dtitov/8015376/webrev.00
backout: http://cr.openjdk.java.net/~dtitov/8059136/webrev.00/

and saw no problems with the backout of the original change.

Pete

Post by Daniil Titov
Hi,
Please review webrev that reverses changes done in the team forest
(https://bugs.openjdk.java.net/browse/JDK-8015376 removal of applet demos).
JDK-8015376 changes were integrated in 8u-dev team forest only, so
there in nothing to reverse in JDK 9.
Both changesets will have to come through 8u-dev forest.
Bug: https://bugs.openjdk.java.net/browse/JDK-8059136
8u40 webrev: http://cr.openjdk.java.net/~dtitov/8059136/webrev.00
<http://cr.openjdk.java.net/%7Edtitov/8059136/webrev.00>
Thanks!
Daniil
-------- Original Message --------
Subject: Re: Request for Approval: 8015376 - Remove jnlp and
applet files from the JDK samples
Date: Thu, 25 Sep 2014 10:01:17 +0100
From: Se?n Coffey <sean.coffey at oracle.com>
To: daniil titov <daniil.x.titov at oracle.com>,
jdk8u-dev at openjdk.java.net
Please add a suitable noreg- label to bug report. (noreg-build I guess)
Approved.
regards,
Sean.

Daniil Titov

2014-09-29 19:16:52 UTC

Permalink

Hi Peter!

Thank you for reviewing this!

--Best regards,
Daniil

Post by Pete Brunet
Hi Daniil, I reviewed the two webrevs
original change: http://cr.openjdk.java.net/~dtitov/8015376/webrev.00
backout: http://cr.openjdk.java.net/~dtitov/8059136/webrev.00/
and saw no problems with the backout of the original change.
Pete

Erik Joelsson

2014-09-30 07:18:43 UTC

Permalink

Hello,

The backout looks clean, ok from me.

/Erik